Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: container did not support setting the timezone via an env variable #6481

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

zoobab
Copy link
Contributor

@zoobab zoobab commented Jun 16, 2021

Problem: container did not support setting the timezone via an env var like '-e TZ=Europe/Brussels'
Solution: adding tzdata package solve this issue

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jannfis
Copy link
Member

jannfis commented Jun 17, 2021

Thanks @zoobab, the change makes sense to me.

Can you please fix the failing CI checks by signing off your commit?

@jannfis jannfis changed the title Problem: container did not support setting the timezone via an env variable chore: container did not support setting the timezone via an env variable Jun 17, 2021
…r like '-e TZ=Europe/Brussels'; Solution: adding tzdata package solve this issue

Signed-off-by: Benjamin Henrion <zoobab@gmail.com>
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #6481 (c36966d) into master (e58d94f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
+ Coverage   41.10%   41.11%   +0.01%     
==========================================
  Files         152      153       +1     
  Lines       20164    20294     +130     
==========================================
+ Hits         8288     8344      +56     
- Misses      10735    10794      +59     
- Partials     1141     1156      +15     
Impacted Files Coverage Δ
util/git/workaround.go 46.87% <0.00%> (-6.07%) ⬇️
util/git/git.go 75.75% <0.00%> (-2.37%) ⬇️
server/application/logs.go 84.48% <0.00%> (-1.24%) ⬇️
cmd/util/repo.go 0.00% <0.00%> (ø)
util/settings/settings.go 46.75% <0.00%> (ø)
cmd/argocd/commands/repo.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/repository_types.go 60.52% <0.00%> (ø)
util/proxy/proxy.go 85.71% <0.00%> (ø)
util/argo/argo.go 61.75% <0.00%> (+0.12%) ⬆️
reposerver/repository/repository.go 61.00% <0.00%> (+0.14%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58d94f...c36966d. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 31be4d8 into argoproj:master Jun 23, 2021
@alexmt alexmt self-assigned this Jul 28, 2021
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@DoumLaberge
Copy link

Can you explain how to set the TZ env when you install ArgoCD with the kubectl apply command?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants