-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ignore preserveUnknownFields in Diff from CRD Spec #6503
Conversation
@@ -550,12 +550,14 @@ func (mgr *SettingsManager) GetResourceOverrides() (map[string]v1alpha1.Resource | |||
} | |||
|
|||
crdGK := "apiextensions.k8s.io/CustomResourceDefinition" | |||
crdPrsvUnkn := "/spec/preserveUnknownFields" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good if these parameters declared as constants along with "status"
Signed-off-by: Subba Reddy Veeramreddy <subbareddyv.uoh@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6503 +/- ##
==========================================
+ Coverage 41.11% 41.12% +0.01%
==========================================
Files 153 153
Lines 20304 20313 +9
==========================================
+ Hits 8348 8354 +6
- Misses 10798 10800 +2
- Partials 1158 1159 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I agree with your suggestions in the comments as well.
Hello :) thanks for this improvement. Is it meant to be included in the 2.0.4 release or the next one please ? |
Follow-up to the previous question : |
Signed-off-by: Subba Reddy Veeramreddy subbareddyv.uoh@gmail.com
Fixes #6401
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: