Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom resource health checks for trident.netapp.io/TridentOrchestrator and trident.netapp.io/TridentBackendConfig (Closes [ISSUE #6550]) #6552

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

Cajga
Copy link
Contributor

@Cajga Cajga commented Jun 24, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

…Orchestrator and trident.netapp.io/TridentBackendConfig

Signed-off-by: Balazs Zachar <zachar.balazs@gmail.com>
@Cajga Cajga force-pushed the trident-custom-health-checks branch from 7106349 to 20ac0b9 Compare June 24, 2021 12:32
…official documentation)

Signed-off-by: Balazs Zachar <zachar.balazs@gmail.com>
@Cajga
Copy link
Contributor Author

Cajga commented Jun 29, 2021

@jannfis, may I ask for a review/feedback please?

@Cajga
Copy link
Contributor Author

Cajga commented Jun 29, 2021

Hmm... Let's hold this a bit, I will try to get feedback from NetAPP on trident.netapp.io/TridentBackendConfig. Based on the documentation using lastOperationStatus may not be the right approach.

The check for trident.netapp.io/TridentOrchestrator is complete and is correct based on the relevant documentation.

@Cajga
Copy link
Contributor Author

Cajga commented Jul 4, 2021

@jannfis, netapp confirmed the approach on the health monitors (see linked ticket). May I ask you for a feedback on this and let me know if there anything else is missing to get this merged?

Thanks

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #6552 (f3c495f) into master (ee8393d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6552      +/-   ##
==========================================
+ Coverage   41.26%   41.28%   +0.02%     
==========================================
  Files         156      156              
  Lines       20675    20684       +9     
==========================================
+ Hits         8531     8540       +9     
+ Misses      10937    10936       -1     
- Partials     1207     1208       +1     
Impacted Files Coverage Δ
util/settings/settings.go 47.00% <0.00%> (-0.28%) ⬇️
cmd/argocd-util/commands/repo.go 0.00% <0.00%> (ø)
server/application/logs.go 85.71% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8393d...f3c495f. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the health checks and tests! LGTM

@alexmt alexmt merged commit 7e68b1e into argoproj:master Jul 9, 2021
@Cajga Cajga deleted the trident-custom-health-checks branch July 9, 2021 06:53
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants