Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify column size of count field #6611

Conversation

saumeya
Copy link
Contributor

@saumeya saumeya commented Jul 1, 2021

Closes issue #5176
Screenshot from 2021-07-01 21-42-00

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@saumeya saumeya force-pushed the count-field-should-be-wide-enough-to-fill-count-#5176 branch from 05fc3b4 to 8295903 Compare July 1, 2021 15:23
@saumeya saumeya changed the title modified count coulumn size Fix: Modify column size of count field Jul 1, 2021
@saumeya saumeya force-pushed the count-field-should-be-wide-enough-to-fill-count-#5176 branch from 8295903 to 7ba247a Compare July 1, 2021 15:38
@saumeya saumeya changed the title Fix: Modify column size of count field fix: Modify column size of count field Jul 1, 2021
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@saumeya saumeya force-pushed the count-field-should-be-wide-enough-to-fill-count-#5176 branch from 7ba247a to 25528ae Compare July 1, 2021 16:02
@reginapizza
Copy link
Contributor

LGTM, should probably still get tooltips eventually but this fixes the issue!

@jannfis
Copy link
Member

jannfis commented Jul 2, 2021

Thanks @saumeya for your contribution, and thanks @reginapizza for the review.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #6611 (25528ae) into master (9b867ff) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
+ Coverage   41.25%   41.30%   +0.04%     
==========================================
  Files         156      156              
  Lines       20672    20688      +16     
==========================================
+ Hits         8529     8545      +16     
- Misses      10935    10936       +1     
+ Partials     1208     1207       -1     
Impacted Files Coverage Δ
util/argo/argo.go 61.75% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.89% <0.00%> (ø)
controller/appcontroller.go 53.36% <0.00%> (+0.09%) ⬆️
util/settings/settings.go 47.27% <0.00%> (+0.27%) ⬆️
server/application/logs.go 85.71% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b867ff...25528ae. Read the comment docs.

@jannfis jannfis merged commit ba4c655 into argoproj:master Jul 2, 2021
@saumeya saumeya deleted the count-field-should-be-wide-enough-to-fill-count-#5176 branch July 6, 2021 06:09
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants