-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Supported set metadata annotations with argocd-util app generate-spec
command
#6633
feat: Supported set metadata annotations with argocd-util app generate-spec
command
#6633
Conversation
…e-spec` command Signed-off-by: takumakume <takuma.kume@pepabo.com>
… command Signed-off-by: takumakume <takuma.kume@pepabo.com>
Codecov Report
@@ Coverage Diff @@
## master #6633 +/- ##
=======================================
Coverage 41.29% 41.30%
=======================================
Files 156 156
Lines 20688 20701 +13
=======================================
+ Hits 8543 8550 +7
- Misses 10937 10943 +6
Partials 1208 1208
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @takumakume for this PR. I agree that this would be useful.
However, I think the command line option should be moved to a different part in the code. AddAppFlags()
sets flags for the .spec
part of the Application
resource, not for its .metadata
section.
I think the right place - despite some redundancy - would be here and here
…e it to the appropriate place Signed-off-by: takumakume <takuma.kume@pepabo.com>
Signed-off-by: takumakume <takuma.kume@pepabo.com>
@jannfis Thank you for the review! |
Signed-off-by: takumakume <takuma.kume@pepabo.com>
Signed-off-by: takumakume <takuma.kume@pepabo.com>
I implemented two more
Please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Hello!
Added support for set metadata annotations with the
argocd-util app generate-spec
command.My use case is to generate Annotations for use with the ArgoCD Image Updater.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: