Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#5462] ArgoCD UI External links dropdown caret positioned incorrectly in list view #6668

Merged

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jul 8, 2021

Fixes #5462
Signed-off-by: ciiay yicai@redhat.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@ciiay ciiay force-pushed the ui-5462-external-links-dropdown-icon-position branch from 97977a9 to 62ca38b Compare July 8, 2021 17:51
@ciiay ciiay changed the title fix(UI) [#5462] ArgoCD UI External links dropdown caret positioned incorrectly in list view fix(UI): [#5462] ArgoCD UI External links dropdown caret positioned incorrectly in list view Jul 8, 2021
@ciiay ciiay changed the title fix(UI): [#5462] ArgoCD UI External links dropdown caret positioned incorrectly in list view fix: [#5462] ArgoCD UI External links dropdown caret positioned incorrectly in list view Jul 8, 2021
@ciiay ciiay force-pushed the ui-5462-external-links-dropdown-icon-position branch from 62ca38b to a31eb53 Compare July 8, 2021 18:57
… incorrectly in list view

Signed-off-by: ciiay <yicai@redhat.com>
@ciiay ciiay force-pushed the ui-5462-external-links-dropdown-icon-position branch from a31eb53 to a96c4a6 Compare July 8, 2021 18:58
Signed-off-by: ciiay <yicai@redhat.com>
@ciiay ciiay force-pushed the ui-5462-external-links-dropdown-icon-position branch from f6fb642 to c81fe58 Compare July 8, 2021 19:58
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #6668 (c81fe58) into master (8030f42) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6668   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files         156      156           
  Lines       20702    20702           
=======================================
  Hits         8550     8550           
  Misses      10944    10944           
  Partials     1208     1208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8030f42...c81fe58. Read the comment docs.

@jannfis jannfis requested a review from reginapizza July 9, 2021 18:44
Copy link
Contributor

@reginapizza reginapizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
issue5462argocd

@jannfis
Copy link
Member

jannfis commented Jul 9, 2021

Thanks @ciiay and 🎉 for your first contribution! And thanks @reginapizza for review & test!

@jannfis jannfis merged commit 040202e into argoproj:master Jul 9, 2021
@jannfis jannfis self-assigned this Jul 13, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD UI External links dropdown caret positioned incorrectly in list view
3 participants