-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Redis SSL support. Fixes #4688 #6742
Conversation
5728442
to
58f2670
Compare
Signed-off-by: Eldar Yusupov <eyusupov@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6742 +/- ##
==========================================
- Coverage 41.30% 40.90% -0.40%
==========================================
Files 156 157 +1
Lines 20702 20957 +255
==========================================
+ Hits 8550 8573 +23
- Misses 10944 11170 +226
- Partials 1208 1214 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @eyusupov ! Added minor comment about linter errors.
Additionally can you add keys for new redis commands to argocd-cmd-params-cm
ConfigMap
redis.db: |
util/cache/cache.go
Outdated
@@ -9,9 +9,12 @@ import ( | |||
|
|||
"github.com/go-redis/redis/v8" | |||
"github.com/spf13/cobra" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix linter error. The following command should do it:
goimports -local github.com/argoproj/argo-cd -w util/cache/cache.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save time reformatted the file and pushed it to your fork.
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
This is similar to #4689, but adds more options to support various scenarios menitioned in the original PR:
insecure tls:
--redis argocd-redis:6379 --redis-use-tls --redis-insecure-skip-tls-verify
self-signed cert on redis server
--redis argocd-redis:6379 --redis-use-tls --redis-ca-certificate /home/argocd/redis-tls/tls.crt --redis-client-certificate /home/argocd/redis-client-tls/tls.crt --redis-client-key /home/argocd/redis-client-tls/tls.key
private ca:
--redis argocd-redis:6379 --redis-use-tls --redis-ca-certificate /home/argocd/ca/tls.crt --redis-client-certificate /home/argocd/redis-client-tls/tls.crt --redis-client-key /home/argocd/redis-client-tls/tls.key
system ca:
--redis argocd-redis:6379 --redis-use-tls --redis-client-certificate /home/argocd/redis-client-tls/tls.crt --redis-client-key /home/argocd/redis-client-tls/tls.key
Looking into updating tests
and the docs