Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Persist visibility of apps list filters in local storage #6748

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jul 16, 2021

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt July 16, 2021 17:26
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #6748 (fa2fb9d) into master (1838fc0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6748   +/-   ##
=======================================
  Coverage   41.31%   41.31%           
=======================================
  Files         156      156           
  Lines       20709    20709           
=======================================
  Hits         8556     8556           
  Misses      10942    10942           
  Partials     1211     1211           
Impacted Files Coverage Δ
util/settings/settings.go 47.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1838fc0...fa2fb9d. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze merged commit ef744e3 into argoproj:master Jul 19, 2021
@rbreeze rbreeze deleted the persist-hide-filters branch July 19, 2021 18:00
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@rbreeze
Copy link
Member Author

rbreeze commented Jul 29, 2021

Tested on Brave (Chromium), Firefox, and Safari

@rbreeze rbreeze removed the needs-verification PR requires pre-release verification label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants