Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add option to wrap lines for pod logs viewer #6889

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Aug 2, 2021

Fixes #5482

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt August 2, 2021 21:02
@rbreeze rbreeze mentioned this pull request Aug 2, 2021
3 tasks
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #6889 (4c86098) into master (e948906) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6889   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files         176      176           
  Lines       22889    22889           
=======================================
  Hits         9713     9713           
  Misses      11790    11790           
  Partials     1386     1386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e948906...4c86098. Read the comment docs.

Signed-off-by: Remington Breeze <remington@breeze.software>
@pasha-codefresh
Copy link
Member

Снимок экрана 2022-02-20 в 15 59 11

Снимок экрана 2022-02-20 в 16 04 14

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@alexmt alexmt merged commit badc828 into argoproj:master Feb 22, 2022
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Feb 23, 2022
Signed-off-by: Remington Breeze <remington@breeze.software>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer word wrap in log viewer
3 participants