Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external OIDC providers and implicit login flows #727

Merged
merged 1 commit into from Oct 29, 2018

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Oct 26, 2018

Resolves #671.

Major refactor of OAuth2/OIDC logic to support OAuth2 authentication in a more generic way. This change enables support for external IDPs without going through dex. We now can perform the implicit OAuth2 login flow, which is required when performing CLI logins directly to external IDPs, which do not have access to the OAuth2 client secret.

External OIDC is configured in the following manner in the argocd.secret:

apiVersion: v1
data:
  url: http://example.com
  oidc.config: |
    name: Okta
    issuer: https://dev-12345.oktapreview.com
    clientID: abc12345

NOTE: we still require some UI changes to create the login button if oidc.config is specified.

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #727 into master will increase coverage by 0.31%.
The diff coverage is 7.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   22.37%   22.69%   +0.31%     
==========================================
  Files          40       40              
  Lines        6252     6174      -78     
==========================================
+ Hits         1399     1401       +2     
+ Misses       4666     4587      -79     
+ Partials      187      186       -1
Impacted Files Coverage Δ
util/oidc/templates.go 0% <ø> (ø)
util/session/sessionmanager.go 27.41% <0%> (+4.6%) ⬆️
server/server.go 30.41% <0%> (-2.79%) ⬇️
util/oidc/oidc.go 2.76% <2.76%> (ø)
util/rand/rand.go 84.61% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2498f60...0ed4eb3. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 5c7a332 into argoproj:master Oct 29, 2018
@jessesuen jessesuen deleted the 671-oidc branch February 12, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants