feat: Allow Banner to be non-closable #7261

[keithchong]

Signed-off-by: Keith Chong kykchong@redhat.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

Fixes #7261

[codecov]

Codecov Report

Merging #7312 (475fec3) into master (bb88a1c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7312      +/-   ##
==========================================
+ Coverage   41.15%   41.20%   +0.04%     
==========================================
  Files         161      161              
  Lines       21553    21628      +75     
==========================================
+ Hits         8871     8911      +40     
- Misses      11415    11448      +33     
- Partials     1267     1269       +2     

Impacted Files	Coverage Δ
util/settings/settings.go	46.77% <100.00%> (+0.06%)	⬆️
controller/cache/cache.go	10.50% <0.00%> (ø)
cmd/argocd/commands/admin/backup.go	0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go	57.51% <0.00%> (ø)
controller/state.go	67.93% <0.00%> (+0.16%)	⬆️
util/argo/resource_tracking.go	83.33% <0.00%> (+14.91%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb88a1c...475fec3. Read the comment docs.

[alexmt]

Thank you @keithchong ! Awesome feature. Noticed a small bug and suggested a fix.

[alexmt]

LGTM