fix: improve migration from label to annotation tracking #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
tracking-method-migration
branch
from
374591f
to
8b2c75d
Compare
pasha-codefresh
requested changes
Dec 10, 2021
util/argo/resource_tracking.go
Outdated
| err = argokube.SetAppInstanceLabel(config, labelKey, label) | ||
| if err != nil { | ||
| return err | ||
| labels := live.GetLabels() |
There was a problem hiding this comment.
I think it will be better move this part to argokube module
|
Thank you for helping solve an issue with the tracking method. I just added a minor comment. |
alexmt
force-pushed
the
tracking-method-migration
branch
2 times, most recently
from
745f9f2
to
bb82e43
Compare
|
Thank you for review @mayzhang2000 and @pasha-codefresh ! PTAL |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
tracking-method-migration
branch
from
bb82e43
to
b9dda1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #7899 +/- ##
==========================================
+ Coverage 41.44% 41.47% +0.02%
==========================================
Files 169 169
Lines 22310 22328 +18
==========================================
+ Hits 9247 9260 +13
- Misses 11741 11744 +3
- Partials 1322 1324 +2
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Dec 11, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
PR resolves two issues related to migration from label to annotation tracking method:
Normalizemethod should not touch "target" resource since it is re-used during the syncing process.