Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cluster API does not support updating labels and annotations #7901

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

mayzhang2000
Copy link
Contributor

@mayzhang2000 mayzhang2000 commented Dec 9, 2021

Signed-off-by: May Zhang may_zhang@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

fixes: #7897

Signed-off-by: May Zhang <may_zhang@intuit.com>
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #7901 (f101940) into master (bea379b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7901      +/-   ##
==========================================
+ Coverage   41.44%   41.46%   +0.01%     
==========================================
  Files         169      169              
  Lines       22310    22316       +6     
==========================================
+ Hits         9247     9253       +6     
  Misses      11741    11741              
  Partials     1322     1322              
Impacted Files Coverage Δ
server/cluster/cluster.go 24.87% <100.00%> (+2.36%) ⬆️
util/settings/settings.go 47.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea379b...f101940. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit a51169e into argoproj:master Dec 10, 2021
alexmt pushed a commit that referenced this pull request Dec 21, 2021
)

Signed-off-by: May Zhang <may_zhang@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster API does not support updating labels and annotations
2 participants