chore: escape proj in regex #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #7985 +/- ##
==========================================
+ Coverage 41.44% 41.49% +0.05%
==========================================
Files 173 173
Lines 22575 22576 +1
==========================================
+ Hits 9357 9369 +12
+ Misses 11886 11875 -11
Partials 1332 1332
Continue to review full report at Codecov.
|
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
pasha-codefresh
approved these changes
Dec 18, 2021
|
LGTM |
alexmt
pushed a commit
that referenced
this pull request
Dec 30, 2021
* chore: escape proj in regex Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: test normal cases Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: typo Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only regex control character that's allowed in a project name is
.. But still, best practice is to escape. Plus code gets copy/pasted, so good to have a solid example.