Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network line colors and menu icon alignment #8059

Merged
merged 2 commits into from Jan 4, 2022

Conversation

saumeya
Copy link
Contributor

@saumeya saumeya commented Dec 29, 2021

closes #2892 - I have changed red green colors to pink and yellow, a different shade of orange and re-ordered the colors.
Also - PR #8054 was making other icons to move as well so adding a specific class as fix for that
current ui
original-colors

changes via this PR
new-pic

Signed-off-by: saumeya saumeyakatyal@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@saumeya saumeya requested a review from alexmt December 29, 2021 21:17
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #8059 (a3204c5) into master (ae9abe5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8059      +/-   ##
==========================================
+ Coverage   41.52%   41.54%   +0.01%     
==========================================
  Files         174      174              
  Lines       22681    22681              
==========================================
+ Hits         9418     9422       +4     
+ Misses      11921    11918       -3     
+ Partials     1342     1341       -1     
Impacted Files Coverage Δ
util/settings/settings.go 46.85% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9abe5...a3204c5. Read the comment docs.

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit c0349f3 into argoproj:master Jan 4, 2022
@maxisam
Copy link

maxisam commented Jun 22, 2022

So could you tell me what does it mean? like why there are different colors for the same service

image

@saumeya
Copy link
Contributor Author

saumeya commented Jun 23, 2022

@maxisam which argocd version are you on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use neutral colors in network view, not red and green
3 participants