Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken TestValidatePermissions unit test #8147

Merged
merged 1 commit into from Jan 11, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 11, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

We've merged two PRs one after another: #8133 and #7976

The second PR introduced a test that is incompatible with changes in the first PR which broke TestValidatePermissions test. PR fixes the broken test.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #8147 (f2301e7) into master (27af0b4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8147      +/-   ##
==========================================
+ Coverage   41.53%   41.54%   +0.01%     
==========================================
  Files         174      174              
  Lines       22736    22741       +5     
==========================================
+ Hits         9443     9448       +5     
  Misses      11949    11949              
  Partials     1344     1344              
Impacted Files Coverage Δ
util/argo/argo.go 63.24% <100.00%> (+0.50%) ⬆️
util/settings/settings.go 47.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd40ef...f2301e7. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 5d770d6 into argoproj:master Jan 11, 2022
@alexmt alexmt deleted the broken-tests-cluster-validation branch January 11, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants