New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow configuring system wide ignore differences for all resources #8224
Conversation
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #8224 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 174 174
Lines 22717 22725 +8
=======================================
+ Hits 9453 9458 +5
- Misses 11908 11910 +2
- Partials 1356 1357 +1
Continue to review full report at Codecov.
|
|
||
```yaml | ||
data: | ||
resource.customizations.ignoreDifferences.all: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add resource.customizations.ignoreDifferences.all
to https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/argocd-cm.yaml as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Forgot about that file.
Pushed a new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add minor comment about updating argocd-cm.yaml. LGTM once it is resolved.
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #7926
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: