fix: Make zoom level a user preference (#7183) #8460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8460 +/- ##
=======================================
Coverage 42.65% 42.65%
=======================================
Files 183 183
Lines 22972 22972
=======================================
Hits 9799 9799
Misses 11790 11790
Partials 1383 1383
Continue to review full report at Codecov.
|
alexmt
requested changes
Feb 13, 2022
There was a problem hiding this comment.
Thank you @keithchong . Noticed one minor issue. Can you take a look?
ui/src/app/applications/components/application-details/application-details.tsx
Outdated
Show resolved
Hide resolved
keithchong
force-pushed
the
7183-MakeZoomLevelViewPreference
branch
2 times, most recently
from
b2ab1a7
to
f129220
Compare
10 tasks
keithchong
force-pushed
the
7183-MakeZoomLevelViewPreference
branch
from
f129220
to
88f93bb
Compare
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
7183-MakeZoomLevelViewPreference
branch
from
88f93bb
to
eed035b
Compare
|
Hi @alexmt, this has been rebased. |
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
Signed-off-by: Keith Chong <kykchong@redhat.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Chong kykchong@redhat.com
No specific issue for this PR, but is a follow-up change to address Alex's comment made here:
#8290 (review)
So, with this change, each browser tab Argo CD UI instance will have the same zoom level.
See bullet point 2 from here: #8290 (comment)
and matches the behavior of the grouped nodes button.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: