Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade redoc #8573

Merged
merged 1 commit into from Feb 18, 2022
Merged

chore: upgrade redoc #8573

merged 1 commit into from Feb 18, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

@crenshaw-dev crenshaw-dev commented Feb 18, 2022

This should resolve several vulnerabilities associated with dependencies used in the /swagger-ui endpoint:

(High) ajv (CVE-2020-15366)
(Medium) marked (SNYK-JS-MARKED-584281)
(Medium) jsonpointer (CVE-2021-23807)
(Medium) marked (CVE-2022-21680)
(Medium) marked (CVE-2022-21681)

I tested by building a new image, loading it in api-server, and poking around the swagger-ui endpoint. Everything seemed to function well.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8573 (821edd3) into master (e948906) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8573   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files         176      176           
  Lines       22889    22889           
=======================================
  Hits         9713     9713           
  Misses      11790    11790           
  Partials     1386     1386           
Impacted Files Coverage Δ
util/settings/settings.go 47.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e948906...821edd3. Read the comment docs.

@alexmt
Copy link
Collaborator

alexmt commented Feb 18, 2022

thank you!

@alexmt alexmt merged commit ae3d6be into argoproj:master Feb 18, 2022
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Feb 23, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
alexmt pushed a commit that referenced this pull request Feb 25, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants