feat: Merge applicationset docs and examples #8955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8955 +/- ##
==========================================
+ Coverage 43.40% 44.92% +1.52%
==========================================
Files 186 212 +26
Lines 23373 25264 +1891
==========================================
+ Hits 10145 11350 +1205
- Misses 11779 12310 +531
- Partials 1449 1604 +155
Continue to review full report at Codecov.
|
|
@jannfis @alexmt @crenshaw-dev : Please 🙏 review this |
crenshaw-dev
requested changes
Mar 31, 2022
There was a problem hiding this comment.
Overall, looks awesome!
A few top-level things:
- I see a few absolute links that could be changed to relative. I think you can find them all with a search for
https://argo-cd.readthedocs.io. - I'm getting an error on
make serve-docs-localregarding thegoogle_analyticsconfig option.
| @@ -0,0 +1,10 @@ | |||
| https://1.2.3.4 | |||
There was a problem hiding this comment.
Since we don't run docs linting in this repo, can we just delete this file?
There was a problem hiding this comment.
is there future plans to do doc linting in this repo?
There was a problem hiding this comment.
@dmolik we disabled it because it was extremely flaky, and the tool we were using wasn't flexible enough to configure away the flakiness.
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
…set to argocd,removed unused file Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
rishabh625
force-pushed
the
merge-applicationset-docs-examples
branch
2 times, most recently
from
36d949d
to
dcff73e
Compare
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
|
Will wait for one more review, since it's a big PR. :-) |
jannfis
approved these changes
Apr 4, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Apr 9, 2022
* feat: Migrate applicationset docs,examples into argocd Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * corrected applicationset binary name in manifest present in doc Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * corrected autogenerated file Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * Included gettimg started page, added relative lookup from applicationset to argocd,removed unused file Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * commiting michael suggestion of text Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
10 tasks
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
* feat: Migrate applicationset docs,examples into argocd Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * corrected applicationset binary name in manifest present in doc Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * corrected autogenerated file Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * Included gettimg started page, added relative lookup from applicationset to argocd,removed unused file Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * commiting michael suggestion of text Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Related #8864
This PR copy's examples and documentation of applicationset into argocd, have changed text of documentation wherever required please review with extra attention as may have mistakes.