feat: New SCM and pull request ApplicationSet generators for Gitea #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmolik
force-pushed
the
gitea
branch
2 times, most recently
from
903018b
to
680a6a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #8989 +/- ##
==========================================
+ Coverage 45.00% 45.13% +0.13%
==========================================
Files 212 214 +2
Lines 25272 25407 +135
==========================================
+ Hits 11373 11468 +95
- Misses 12292 12325 +33
- Partials 1607 1614 +7
Continue to review full report at Codecov.
|
An initial implementation of Pull Request and SCM generators for Gitea. API paging, and repo labels have not been implemented. Signed-off-by: Dan Molik <dan@danmolik.com>
re-trigger linting check Signed-off-by: Dan Molik <dan@danmolik.com>
crenshaw-dev
requested changes
Apr 5, 2022
There was a problem hiding this comment.
Do you have time to put some test coverage on the new code?
I think mocks would be appropriate for testing generators/. For services/ we could either try to find a hosted gitea instance to rely on (like in the gitlab tests), try to spin one up in e2e tests, or just leave it untested.
|
I guess even the services/* files can be tested with giteaProvider and giteaService mocks. |
|
Okay I just need to rebase or sign my commit |
|
@dmolik yep looks like the most recent 2 commits need to be signed. I think the DCO check details should have instructions for signing multiple commits. |
|
Yea I really should just turn auto signing on |
Signed-off-by: Dan Molik <dan@danmolik.com>
rishabh625
suggested changes
Apr 6, 2022
Signed-off-by: Dan Molik <dan@danmolik.com>
|
@rishabh625 if you're happy, I'll merge! |
rishabh625
reviewed
Apr 6, 2022
rishabh625
approved these changes
Apr 7, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Apr 9, 2022
…rgoproj#8989) * feat: New SCM and pull request ApplicationSet generators for Gitea An initial implementation of Pull Request and SCM generators for Gitea. API paging, and repo labels have not been implemented. Signed-off-by: Dan Molik <dan@danmolik.com> * chore: white space in hack/test.sh re-trigger linting check Signed-off-by: Dan Molik <dan@danmolik.com> * chore: add gitea_scm and gitea_pr tests Signed-off-by: Dan Molik <dan@danmolik.com> * bug: ensure gitea scm haspath detects directories correctly Signed-off-by: Dan Molik <dan@danmolik.com> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
…rgoproj#8989) * feat: New SCM and pull request ApplicationSet generators for Gitea An initial implementation of Pull Request and SCM generators for Gitea. API paging, and repo labels have not been implemented. Signed-off-by: Dan Molik <dan@danmolik.com> * chore: white space in hack/test.sh re-trigger linting check Signed-off-by: Dan Molik <dan@danmolik.com> * chore: add gitea_scm and gitea_pr tests Signed-off-by: Dan Molik <dan@danmolik.com> * bug: ensure gitea scm haspath detects directories correctly Signed-off-by: Dan Molik <dan@danmolik.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial implementation of Pull Request and SCM generators for Gitea.
API paging, and repo labels have not been implemented.
Signed-off-by: Dan Molik dan@danmolik.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: