-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add caching to application js bundle since it has a unique name #9008
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9008 +/- ##
==========================================
- Coverage 45.07% 45.03% -0.05%
==========================================
Files 212 212
Lines 25281 25285 +4
==========================================
- Hits 11396 11387 -9
- Misses 12278 12293 +15
+ Partials 1607 1605 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. I had some suggestions, but they were complex enough to justify a PR. lmk what you think: backjo#1
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
…argoproj#9008) * feat: add caching to application js bundle since it has a unique name Signed-off-by: Jonah Back <jonah@jonahback.com> * chore: simplify check and add tests Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
…argoproj#9008) * feat: add caching to application js bundle since it has a unique name Signed-off-by: Jonah Back <jonah@jonahback.com> * chore: simplify check and add tests Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Add caching of UI bundle to improve performance when reloading ArgoCD.
Signed-off-by: Jonah Back jonah@jonahback.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: