Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caching to application js bundle since it has a unique name #9008

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Apr 5, 2022

Add caching of UI bundle to improve performance when reloading ArgoCD.

Signed-off-by: Jonah Back jonah@jonahback.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #9008 (fd8bbcf) into master (5921e2a) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head fd8bbcf differs from pull request most recent head e0d8633. Consider uploading reports for the commit e0d8633 to get more accurate results

@@            Coverage Diff             @@
##           master    #9008      +/-   ##
==========================================
- Coverage   45.07%   45.03%   -0.05%     
==========================================
  Files         212      212              
  Lines       25281    25285       +4     
==========================================
- Hits        11396    11387       -9     
- Misses      12278    12293      +15     
+ Partials     1607     1605       -2     
Impacted Files Coverage Δ
server/server.go 55.53% <50.00%> (-0.04%) ⬇️
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
util/settings/settings.go 48.10% <0.00%> (ø)
applicationset/services/scm_provider/utils.go 88.50% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5921e2a...e0d8633. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. I had some suggestions, but they were complex enough to justify a PR. lmk what you think: backjo#1

backjo and others added 2 commits April 6, 2022 20:50
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator

image

Nice! 🎉

@crenshaw-dev crenshaw-dev merged commit 14cdfc7 into argoproj:master Apr 7, 2022
@backjo backjo deleted the feat/jsCaching branch April 7, 2022 16:42
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022
…argoproj#9008)

* feat: add caching to application js bundle since it has a unique name

Signed-off-by: Jonah Back <jonah@jonahback.com>

* chore: simplify check and add tests

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
…argoproj#9008)

* feat: add caching to application js bundle since it has a unique name

Signed-off-by: Jonah Back <jonah@jonahback.com>

* chore: simplify check and add tests

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants