-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add permission check to argocd-cli #9057
fix: add permission check to argocd-cli #9057
Conversation
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #9057 +/- ##
==========================================
- Coverage 45.21% 45.17% -0.05%
==========================================
Files 214 214
Lines 25436 25444 +8
==========================================
- Hits 11502 11495 -7
- Misses 12313 12331 +18
+ Partials 1621 1618 -3
Continue to review full report at Codecov.
|
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
tested in my local and here the output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @ashutosh16!
* add permission check to argocd-cli Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com> * Retrigger CI pipeline Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com> Co-authored-by: asingh51 <Ashutosh_Singh@intuit.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Signed-off-by: Ashutosh
This is a fix for #5780
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: