-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove cookie module from ui #9088
Merged
crenshaw-dev
merged 12 commits into
argoproj:master
from
pasha-codefresh:snyk-cookie-dep
Apr 18, 2022
Merged
fix: remove cookie module from ui #9088
crenshaw-dev
merged 12 commits into
argoproj:master
from
pasha-codefresh:snyk-cookie-dep
Apr 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io> # Conflicts: # OWNERS
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io> # Conflicts: # ui/package.json
Codecov Report
@@ Coverage Diff @@
## master #9088 +/- ##
==========================================
- Coverage 45.48% 45.44% -0.05%
==========================================
Files 217 217
Lines 25655 25655
==========================================
- Hits 11669 11658 -11
- Misses 12357 12371 +14
+ Partials 1629 1626 -3
Continue to review full report at Codecov.
|
crenshaw-dev
approved these changes
Apr 18, 2022
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
* add to approvers Signed-off-by: pashavictorovich <pavel@codefresh.io> * remove cookie module Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an upgrade reported by snyk i have noticed that we are not using cookie module anymore
#9073