Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cookie module from ui #9088

Merged
merged 12 commits into from
Apr 18, 2022

Conversation

pasha-codefresh
Copy link
Member

Due to an upgrade reported by snyk i have noticed that we are not using cookie module anymore

#9073

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #9088 (1290c72) into master (fa46ac1) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9088      +/-   ##
==========================================
- Coverage   45.48%   45.44%   -0.05%     
==========================================
  Files         217      217              
  Lines       25655    25655              
==========================================
- Hits        11669    11658      -11     
- Misses      12357    12371      +14     
+ Partials     1629     1626       -3     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
applicationset/services/scm_provider/utils.go 88.50% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa46ac1...1290c72. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit 7494090 into argoproj:master Apr 18, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
* add to approvers

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* remove cookie module

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants