fix: add writable /tmp mount for the applicationset controller

[crenshaw-dev]

The applicationset controller needs a writeable /tmp volume since it clones git repos.

Regression due to #9087 but is not in any released version.

Another reason to do this: #8948

[codecov]

Codecov Report

Merging #9183 (8535a9b) into master (e5e3b0f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9183      +/-   ##
==========================================
- Coverage   45.53%   45.51%   -0.02%     
==========================================
  Files         219      219              
  Lines       25897    25897              
==========================================
- Hits        11792    11787       -5     
- Misses      12463    12467       +4     
- Partials     1642     1643       +1     

Impacted Files	Coverage Δ
applicationset/services/scm_provider/github.go	75.29% <0.00%> (-5.89%)	⬇️
util/settings/settings.go	48.10% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e3b0f...8535a9b. Read the comment docs.

[rishabh625]

Same problem with repo-server too

[crenshaw-dev]

Looks like repo-server already has a /tmp volume mount.

argo-cd/manifests/base/repo-server/argocd-repo-server-deployment.yaml

Line 142 in b760a27

mountPath: /tmp

[jannfis]

LGTM, thank you @crenshaw-dev !