fix: throw better error if default branch is missing in gitea #9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
|
@rishabh625 here's the alternative fix for the unit test failure. |
Codecov Report
@@ Coverage Diff @@
## master #9228 +/- ##
==========================================
+ Coverage 45.53% 45.79% +0.26%
==========================================
Files 219 219
Lines 25897 25864 -33
==========================================
+ Hits 11792 11845 +53
+ Misses 12463 12373 -90
- Partials 1642 1646 +4
Continue to review full report at Codecov.
|
leoluz
reviewed
Apr 27, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
rishabh625
approved these changes
Apr 27, 2022
crenshaw-dev
changed the title
crenshaw-dev
added a commit
to josephmcasey/argo-cd
that referenced
this pull request
Apr 27, 2022
…rgoproj#9228) * fix: fall back to only branch if default branch is missing in gitea Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * throw meaningful error, use different org for test Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
This was referenced Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gitea unit test is failing because the gitea API is returning
mainas the default branch for https://gitea.com/gitea/test-openldap when the only existing branch ismaster.I've modified the "get branch" logic to fall back to the only branch if the default branch is missing.