Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable webpack dev-server compression #9285

Merged
merged 1 commit into from May 3, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 3, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR disables compression of webpack dev server to fix SSE calls. The SSE response cannot be gzipped because content is delivered in chunks.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #9285 (d47e5d0) into master (216edee) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9285      +/-   ##
==========================================
- Coverage   45.97%   45.95%   -0.02%     
==========================================
  Files         217      217              
  Lines       25903    25903              
==========================================
- Hits        11910    11905       -5     
- Misses      12336    12340       +4     
- Partials     1657     1658       +1     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216edee...d47e5d0. Read the comment docs.

@alexmt alexmt merged commit 1eabf99 into argoproj:master May 3, 2022
@alexmt alexmt deleted the fix-dev-streams branch May 3, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants