Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: logs RBAC upgrate notes #9345

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

crenshaw-dev
Copy link
Collaborator

I think we should guide people towards using logs RBAC enforcement early so we can catch any bugs.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #9345 (65c46c3) into master (0800921) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9345      +/-   ##
==========================================
+ Coverage   46.06%   46.14%   +0.08%     
==========================================
  Files         217      217              
  Lines       25912    25912              
==========================================
+ Hits        11936    11958      +22     
+ Misses      12319    12297      -22     
  Partials     1657     1657              
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)
cmd/argocd/commands/app.go 19.44% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0800921...65c46c3. Read the comment docs.

Copy link
Member

@kostis-codefresh kostis-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pasha-codefresh pasha-codefresh merged commit 543f922 into master May 10, 2022
@pasha-codefresh pasha-codefresh deleted the logs-rbac-upgrade-notes branch May 10, 2022 16:02
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this pull request May 11, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev added a commit that referenced this pull request May 11, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked into 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants