-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: logs RBAC upgrate notes #9345
Conversation
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #9345 +/- ##
==========================================
+ Coverage 46.06% 46.14% +0.08%
==========================================
Files 217 217
Lines 25912 25912
==========================================
+ Hits 11936 11958 +22
+ Misses 12319 12297 -22
Partials 1657 1657
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Cherry-picked into 2.4. |
I think we should guide people towards using logs RBAC enforcement early so we can catch any bugs.