Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify Role/ClusterRole uses for exec feature #9354

Merged
merged 2 commits into from
May 12, 2022
Merged

docs: clarify Role/ClusterRole uses for exec feature #9354

merged 2 commits into from
May 12, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

Related to #9335

@crenshaw-dev
docs: clarify Role/ClusterRole uses for exec feature
7833062 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #9354 (362bb6d) into master (016fd5f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9354      +/-   ##
==========================================
- Coverage   46.19%   46.17%   -0.02%     
==========================================
  Files         218      218              
  Lines       25917    25917              
==========================================
- Hits        11972    11967       -5     
- Misses      12290    12294       +4     
- Partials     1655     1656       +1
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016fd5f...362bb6d. Read the comment docs.

34fathombelow
34fathombelow reviewed May 11, 2022
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update line 82
p, role:org-admin, exec, create, *, allow

34fathombelow
34fathombelow requested changes May 11, 2022
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update line 98
p, role:staging-db-admins, exec, create, staging-db-admins/*, allow
also line 103
This example defines a *role* called `staging-db-admins` with *eight permissions* that allow that role to perform the *actions* (`create`/`delete`/`get`/`override`/`sync`/`update` applications, `get` logs, `create` exec and `get` appprojects) against `*` (all) objects in the `staging-db-admins` Argo CD AppProject.

@crenshaw-dev
fix missed gets
362bb6d 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review May 11, 2022 13:40
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 11, 2022
leoluz
leoluz approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 15a2bec into argoproj:master May 12, 2022
@crenshaw-dev crenshaw-dev deleted the more-exec-rbac-docs branch May 12, 2022 15:13
crenshaw-dev added a commit that referenced this pull request May 12, 2022
@crenshaw-dev
docs: clarify Role/ClusterRole uses for exec feature (#9354)
1998b01 
* docs: clarify Role/ClusterRole uses for exec feature

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix missed `get`s

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked into 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@34fathombelow 34fathombelow 34fathombelow requested changes

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crenshaw-dev @leoluz @34fathombelow