fix: ListResourceActions() returns duplicate actions

[chetan-rns]

ListResourceActions() API is returning duplicate actions. The issue is because of appending the pointer of the range variable instead of the actual element of the slice.

{"actions":[{"name":"resume","disabled":true},{"name":"resume","disabled":true}]}

Fixes: #9334

Signed-off-by: Chetan Banavikalmutt chetanrns1997@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[chetan-rns]

I think we should also cherry-pick this fix to v2.4.0

[codecov]

Codecov Report

Merging #9360 (a4426bd) into master (f75e881) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #9360      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.01%     
==========================================
  Files         218      218              
  Lines       25917    25917              
==========================================
- Hits        11972    11970       -2     
  Misses      12290    12290              
- Partials     1655     1657       +2     

Impacted Files	Coverage Δ
server/application/application.go	31.83% <0.00%> (ø)
applicationset/services/scm_provider/github.go	75.29% <0.00%> (-5.89%)	⬇️
util/settings/settings.go	48.16% <0.00%> (ø)
server/server.go	54.63% <0.00%> (+0.51%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75e881...a4426bd. Read the comment docs.

[crenshaw-dev]

lgtm! A test would be nice, but I see this is in a relatively difficult-to-test area.

[crenshaw-dev]

Cherry-picked to 2.4.