Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve otel grpc traces adding span correlation #9371

Merged
merged 6 commits into from
May 13, 2022

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented May 11, 2022

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested a review from crenshaw-dev May 11, 2022 19:34
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #9371 (3adc92f) into master (f75e881) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9371      +/-   ##
==========================================
- Coverage   46.19%   45.78%   -0.42%     
==========================================
  Files         218      220       +2     
  Lines       25917    26170     +253     
==========================================
+ Hits        11972    11981       +9     
- Misses      12290    12531     +241     
- Partials     1655     1658       +3     
Impacted Files Coverage Δ
server/server.go 54.28% <100.00%> (+0.15%) ⬆️
...is/applicationset/v1alpha1/applicationset_types.go 27.58% <0.00%> (-7.11%) ⬇️
applicationset/services/scm_provider/gitlab.go 74.19% <0.00%> (-2.16%) ⬇️
applicationset/services/scm_provider/github.go 81.17% <0.00%> (ø)
pkg/apiclient/apiclient.go 0.68% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
server/application/logs.go 85.71% <0.00%> (+4.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75e881...3adc92f. Read the comment docs.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for supporting this.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 12, 2022
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 13, 2022 17:22
@crenshaw-dev crenshaw-dev merged commit 1246e15 into argoproj:master May 13, 2022
@leoluz leoluz deleted the grpc-spans branch May 13, 2022 18:20
leoluz added a commit to leoluz/argo-cd that referenced this pull request May 13, 2022
* chore: Improve otel grpc traces adding span correlation

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Create a tracer for argocd controller

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Update controller command doc

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Instrument cmp-client

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add otlp config as part of configmaps

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* update manifests

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked to 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants