Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document new repo-server ServiceAccount #9484

Merged
merged 1 commit into from
May 31, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

Thanks to Raymond Wong for pointing out that the ServiceAccount change might cause problems for non-default setups.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #9484 (5703027) into master (ba7d2e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9484   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7d2e7...5703027. Read the comment docs.

@crenshaw-dev crenshaw-dev requested a review from leoluz May 24, 2022 14:53
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 24, 2022
@leoluz leoluz merged commit 226b789 into argoproj:master May 31, 2022
@crenshaw-dev crenshaw-dev deleted the document-new-serviceaccount branch May 31, 2022 16:28
crenshaw-dev added a commit that referenced this pull request May 31, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked into 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants