fix: api server should dynamically enabled terminal handler #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
jessesuen
approved these changes
May 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #9497 +/- ##
==========================================
- Coverage 45.71% 45.70% -0.02%
==========================================
Files 221 221
Lines 26289 26293 +4
==========================================
- Hits 12019 12018 -1
- Misses 12610 12615 +5
Partials 1660 1660
Continue to review full report at Codecov.
|
alexmt
added a commit
that referenced
this pull request
May 24, 2022
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
added
the
cherry-pick/2.4
|
Cherry-picked to 2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
The
terminalhandler should be dynamically enabled/disabled, based onexec.enabledsetting without server restart.