Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web terminal due to query parameters name mismatch #9560

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 1, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #9560 (282efd2) into master (5edaa6c) will decrease coverage by 0.10%.
The diff coverage is 41.12%.

@@            Coverage Diff             @@
##           master    #9560      +/-   ##
==========================================
- Coverage   45.86%   45.76%   -0.11%     
==========================================
  Files         221      222       +1     
  Lines       26309    26380      +71     
==========================================
+ Hits        12067    12072       +5     
- Misses      12586    12646      +60     
- Partials     1656     1662       +6     
Impacted Files Coverage Δ
controller/appcontroller.go 52.07% <0.00%> (-0.21%) ⬇️
util/argo/managedfields/parser.go 100.00% <ø> (ø)
util/app/discovery/discovery.go 40.27% <33.33%> (ø)
util/argo/managedfields/managed_fields.go 42.04% <36.61%> (-32.96%) ⬇️
cmpserver/plugin/plugin.go 49.28% <50.00%> (+1.80%) ⬆️
controller/state.go 73.64% <50.00%> (-0.26%) ⬇️
controller/sync.go 56.84% <50.00%> (-0.12%) ⬇️
util/argo/diff/diff.go 52.20% <60.00%> (-0.07%) ⬇️
reposerver/repository/repository.go 61.49% <66.66%> (+0.08%) ⬆️
server/application/terminal.go 12.83% <66.66%> (-11.49%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f48d5...282efd2. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this work ever?

NVMD saw the other PR that broke it

@alexmt alexmt merged commit dee550a into argoproj:master Jun 1, 2022
@alexmt alexmt deleted the terminal-query-params branch June 1, 2022 21:39
alexmt added a commit that referenced this pull request Jun 1, 2022
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants