Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix cm typo in google docs #9577

Merged
merged 1 commit into from
Jun 3, 2022
Merged

docs: fix cm typo in google docs #9577

merged 1 commit into from
Jun 3, 2022

Conversation

bjorn-stange-expel
Copy link
Contributor

The configmap set up by the installer is argocd-cm not argo-cm, so I assume this is a typo?

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Bjorn Stange <bjorn.stange@expel.io>
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #9577 (ba164ef) into master (7ca8c11) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9577   +/-   ##
=======================================
  Coverage   45.79%   45.79%           
=======================================
  Files         222      222           
  Lines       26377    26377           
=======================================
  Hits        12079    12079           
  Misses      12650    12650           
  Partials     1648     1648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca8c11...ba164ef. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev merged commit 68c7e7d into argoproj:master Jun 3, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 3, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 3, 2022
Signed-off-by: Bjorn Stange <bjorn.stange@expel.io>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto 2.4.

huynhj93 pushed a commit to huynhj93/argo-cd that referenced this pull request Jun 13, 2022
Signed-off-by: Bjorn Stange <bjorn.stange@expel.io>
Signed-off-by: John Huynh <johnhuynh@admins-MacBook-Pro-5.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants