fix: resource eventsource duplicate update events. Fixes #760 (#1025) (…

…#1404) Signed-off-by: dubeau <28494057+dubeau@users.noreply.github.com>
argoproj · Nov 3, 2021 · aff2726 · aff2726
1 parent 4a1bf22
commit aff2726
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/eventsources/sources/resource/start.go b/eventsources/sources/resource/start.go
@@ -199,6 +199,12 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt
 		case v1alpha1.UPDATE:
 			handlerFuncs.UpdateFunc = func(oldObj, newObj interface{}) {
 				log.Info("detected update event")
+				uNewObj := newObj.(*unstructured.Unstructured)
+				uOldObj := oldObj.(*unstructured.Unstructured)
+				if uNewObj.GetResourceVersion() == uOldObj.GetResourceVersion() {
+					log.Infof("rejecting update event with identical resource versions: %s", uNewObj.GetResourceVersion())
+					return
+				}
 				informerEventCh <- &InformerEvent{
 					Obj:    newObj,
 					OldObj: oldObj,