-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check update reason in k8s resource eventsource #1025
Comments
Is this a bug? I think I'd only like 1 update. |
I think this could be considered a bug. In fact this looks related to #760 to add some context:
|
@scottweitzner - Have you specified https://github.com/argoproj/argo-events/blob/master/examples/event-sources/resource.yaml#L26? |
@whynowy I have
Some additional requirements/nice to have would be to check what value has changed (if at all possible) that way we could filter and only trigger if say one portion of a configmap changed from/to. k8s: |
…argoproj#1025) Signed-off-by: dubeau <28494057+dubeau@users.noreply.github.com>
…argoproj#1025) (argoproj#1404) Signed-off-by: dubeau <28494057+dubeau@users.noreply.github.com>
I've seen this behaviour as well. If i may add reproduce steps:
The issue occurs when it seems that the ES pod "recollects" events from NATS.
Even with
|
Adding to this, when Informer used is found here |
I can confirm that v1.5.4 fixes the issue i've described above. |
…argoproj#1025) (argoproj#1404) Signed-off-by: dubeau <28494057+dubeau@users.noreply.github.com>
Description
My team and I noticed (due to an accumulation of finished jobs) that for resource eventsources if you have update events enabled then your downstream sensor/trigger will be triggered many times even when the resource (a configmap in our case) is not updated. This is due to the fact that the watcher dies. My guess is that when the watch is re-established argoevents can't (or doesn't) distinguish it from a true update.
Proposal
Within the resource sensor we can compare the old body object to the new body object and if they are identical, we can ignore the event. See here
/cc @VaibhavPage
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: