feat(lambda-trigger): expose Lambda invocation type. Closes: #994 (#1187

) * feat(lambda-trigger): expose Lambda invocation type. Closes: #994 Signed-off-by: Derek Wang <whynowy@gmail.com> * example Signed-off-by: Derek Wang <whynowy@gmail.com>
argoproj · Apr 23, 2021 · c71d10d · c71d10d
1 parent 79cae5c
commit c71d10d
Show file tree

Hide file tree

Showing 10 changed files with 410 additions and 244 deletions.
diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
diff --git a/api/sensor.html b/api/sensor.html
diff --git a/api/sensor.md b/api/sensor.md
diff --git a/examples/sensors/aws-lambda-trigger.yaml b/examples/sensors/aws-lambda-trigger.yaml
@@ -24,3 +24,6 @@ spec:
                 dependencyName: test-dep
                 dataKey: body.name
               dest: name
+          # Optional, possible values: RequestResponse, Event and DryRun
+          # Defaults to RequestResponse, which means invoke the function synchronously.
+          invocationType: Event
diff --git a/pkg/apis/sensor/v1alpha1/generated.pb.go b/pkg/apis/sensor/v1alpha1/generated.pb.go
diff --git a/pkg/apis/sensor/v1alpha1/generated.proto b/pkg/apis/sensor/v1alpha1/generated.proto
diff --git a/pkg/apis/sensor/v1alpha1/openapi_generated.go b/pkg/apis/sensor/v1alpha1/openapi_generated.go
diff --git a/pkg/apis/sensor/v1alpha1/types.go b/pkg/apis/sensor/v1alpha1/types.go
@@ -435,13 +435,25 @@ type AWSLambdaTrigger struct {
 	// Region is AWS region
 	Region string `json:"region" protobuf:"bytes,4,opt,name=region"`
 	// Payload is the list of key-value extracted from an event payload to construct the request payload.
-
 	Payload []TriggerParameter `json:"payload" protobuf:"bytes,5,rep,name=payload"`
 	// Parameters is the list of key-value extracted from event's payload that are applied to
 	// the trigger resource.
-
 	// +optional
 	Parameters []TriggerParameter `json:"parameters,omitempty" protobuf:"bytes,6,rep,name=parameters"`
+	// Choose from the following options.
+	//
+	//    * RequestResponse (default) - Invoke the function synchronously. Keep
+	//    the connection open until the function returns a response or times out.
+	//    The API response includes the function response and additional data.
+	//
+	//    * Event - Invoke the function asynchronously. Send events that fail multiple
+	//    times to the function's dead-letter queue (if it's configured). The API
+	//    response only includes a status code.
+	//
+	//    * DryRun - Validate parameter values and verify that the user or role
+	//    has permission to invoke the function.
+	// +optional
+	InvocationType *string `json:"invocationType,omitempty" protobuf:"bytes,7,opt,name=invocationType"`
 }
 
 // AzureEventHubsTrigger refers to specification of the Azure Event Hubs Trigger

diff --git a/pkg/apis/sensor/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/sensor/v1alpha1/zz_generated.deepcopy.go
diff --git a/sensors/triggers/aws-lambda/aws-lambda.go b/sensors/triggers/aws-lambda/aws-lambda.go
@@ -114,8 +114,9 @@ func (t *AWSLambdaTrigger) Execute(ctx context.Context, events map[string]*v1alp
 	}
 
 	response, err := t.LambdaClient.Invoke(&lambda.InvokeInput{
-		FunctionName: &trigger.FunctionName,
-		Payload:      payload,
+		FunctionName:   &trigger.FunctionName,
+		Payload:        payload,
+		InvocationType: trigger.InvocationType,
 	})
 	if err != nil {
 		return nil, err