feat(github-eventsource): Support multi repos and mitigate race condi…

…tions (#1181) * feat(github-eventsource): Support multi repos and mitigate race conditions Signed-off-by: Derek Wang <whynowy@gmail.com>
argoproj · May 4, 2021 · ebc1fac · ebc1fac
1 parent 69c36cd
commit ebc1fac
Show file tree

Hide file tree

Showing 22 changed files with 1,172 additions and 571 deletions.
diff --git a/api/event-source.html b/api/event-source.html
diff --git a/api/event-source.md b/api/event-source.md
diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
diff --git a/docs/eventsources/webhook-health-check.md b/docs/eventsources/webhook-health-check.md
@@ -1,17 +1,13 @@
 # Webhook Health Check
 
-![GA](../assets/ga.svg)
-
-> v1.0 and after
-
 For `webhook` or `webhook` extended event sources such as `github`, `gitlab`,
 `sns`, `slack`, `Storage GRID` and `stripe`, besides the endpoint configured in
 the spec, an extra endpoint `:${port}/health` will also be created, this is
 useful for LB or Ingress configuration for the event source, where usually a
 health check endpoint is required.
 
 For example, the following EventSource object will have 4 endpoints created,
-`:12000/example1`, `:12000/health`, `:13000/example2` and `:13000/health`. A
+`:12000/example1`, `:12000/health`, `:13000/example2` and `:13000/health`. An
 HTTP GET request to the health endpoint returns a text `OK` with HTTP response
 code `200`.
 

diff --git a/docs/tutorials/01-introduction.md b/docs/tutorials/01-introduction.md
@@ -18,7 +18,7 @@ to any type of event-source.
   [instruction](https://github.com/argoproj/argo-events/tree/master/examples) to
   create a Service Account `operate-workflow-sa` with proper privileges, and
   make sure the Service Account used by Workflows (here we use `default` in the
-  turorials for demostration purpose) has proper RBAC settings.
+  turorials for demonstration purpose) has proper RBAC settings.
 
 ## Get Started
 

diff --git a/eventbus/driver/nats.go b/eventbus/driver/nats.go
@@ -167,6 +167,7 @@ func (n *natsStreaming) SubscribeEventSources(ctx context.Context, conn Connecti
 		defer wg.Done()
 		log.Info("starting ExactOnce cache clean up daemon ...")
 		ticker := time.NewTicker(60 * time.Second)
+		defer ticker.Stop()
 		for {
 			select {
 			case <-cacheEvictorStopCh:

diff --git a/eventsources/eventing.go b/eventsources/eventing.go
@@ -331,6 +331,7 @@ func (e *EventSourceAdaptor) run(ctx context.Context, servers map[apicommon.Even
 		defer connWG.Done()
 		logger.Info("starting eventbus connection daemon...")
 		ticker := time.NewTicker(5 * time.Second)
+		defer ticker.Stop()
 		for {
 			select {
 			case <-cctx.Done():

diff --git a/eventsources/sources/generic/start.go b/eventsources/sources/generic/start.go
@@ -57,6 +57,7 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt
 
 	logger.Info("connecting to eventsource server in 5 seconds...")
 	ticker := time.NewTicker(5 * time.Second)
+	defer ticker.Stop()
 	for {
 		select {
 		case <-ctx.Done():