fix(controller): use a copied object to update because of mutation (#…

…2466) Signed-off-by: Derek Wang <whynowy@gmail.com>
argoproj · Mar 3, 2023 · f28cde2 · f28cde2
1 parent 201b833
commit f28cde2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/controllers/eventbus/controller.go b/controllers/eventbus/controller.go
@@ -58,7 +58,8 @@ func (r *reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		log.Errorw("reconcile error", zap.Error(reconcileErr))
 	}
 	if r.needsUpdate(eventBus, busCopy) {
-		if err := r.client.Update(ctx, busCopy); err != nil {
+		// Use a DeepCopy to update, because it will be mutated afterwards, with empty Status.
+		if err := r.client.Update(ctx, busCopy.DeepCopy()); err != nil {
 			return reconcile.Result{}, err
 		}
 	}

diff --git a/controllers/eventsource/controller.go b/controllers/eventsource/controller.go
@@ -55,7 +55,8 @@ func (r *reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		log.Errorw("reconcile error", zap.Error(reconcileErr))
 	}
 	if r.needsUpdate(eventSource, esCopy) {
-		if err := r.client.Update(ctx, esCopy); err != nil {
+		// Use a DeepCopy to update, because it will be mutated afterwards, with empty Status.
+		if err := r.client.Update(ctx, esCopy.DeepCopy()); err != nil {
 			return reconcile.Result{}, err
 		}
 	}

diff --git a/controllers/sensor/controller.go b/controllers/sensor/controller.go
@@ -74,7 +74,8 @@ func (r *reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		log.Errorw("reconcile error", zap.Error(reconcileErr))
 	}
 	if r.needsUpdate(sensor, sensorCopy) {
-		if err := r.client.Update(ctx, sensorCopy); err != nil {
+		// Use a DeepCopy to update, because it will be mutated afterwards, with empty Status.
+		if err := r.client.Update(ctx, sensorCopy.DeepCopy()); err != nil {
 			return reconcile.Result{}, err
 		}
 	}