fix(controller): use a copied object to update because of mutation #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
dfarr
approved these changes
Mar 1, 2023
|
Looks good! Very clean solution |
sarabala1979
approved these changes
Mar 2, 2023
jwillker
pushed a commit
to jwillker/argo-events
that referenced
this pull request
Mar 29, 2023
…rgoproj#2466) Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: JohnWillker <frazao.jhonn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang whynowy@gmail.com
Controller-runtime client.Update() will mutate the object, which makes the following up Status.Update() do nothing - it didn't cause any issue because there are couple of reconciliations, eventually the Status gets updated correctly.
Thanks @dfarr @bilalba for reporting the issue.
Checklist: