-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support append/prepend operations for trigger parameters #315
Comments
Looks like a nice feature to have. I'll add it in the next release. |
marxarelli
added a commit
to marxarelli/argo-events
that referenced
this issue
Jul 26, 2019
Implemented an additional `operation` field for trigger parameters that dictates what is to be done with the current value at `dest`. Possible keyword values are: - `overwrite` Overwrite the current value (default/prior behavior) - `prepend` Prepend the value at `dest` with the value at `source.path` - `append` Append the value at `dest` with the value at `source.path`
VaibhavPage
pushed a commit
that referenced
this issue
Jul 27, 2019
* Support different trigger parameter operations (#315) Implemented an additional `operation` field for trigger parameters that dictates what is to be done with the current value at `dest`. Possible keyword values are: - `overwrite` Overwrite the current value (default/prior behavior) - `prepend` Prepend the value at `dest` with the value at `source.path` - `append` Append the value at `dest` with the value at `source.path` * Specified that `operation` is optional and generated openapi specs
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this issue
Mar 29, 2022
…oj#319) * Support different trigger parameter operations (argoproj#315) Implemented an additional `operation` field for trigger parameters that dictates what is to be done with the current value at `dest`. Possible keyword values are: - `overwrite` Overwrite the current value (default/prior behavior) - `prepend` Prepend the value at `dest` with the value at `source.path` - `append` Append the value at `dest` with the value at `source.path` * Specified that `operation` is optional and generated openapi specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I'm looking to use Argo Events to respond to patchset-created events generated by Gerrit code review, creating a workflow that runs CI tasks based on a workflow file stored in the patchset's project repo. Gerrit does not include the full clone URL for the project in the event data and so it must be constructed from a prefix and the project name. However, this isn't possible given the fact that
templateParameters
can only overwrite values, not prepend/append existing ones.Describe the solution you'd like
I would love a
TriggerParameter.Operation
field of some sort that supported keywords such asoverwrite
(default),prepend
, andappend
. (Or something similar that achieves the desired functionality.) I'm down to author a pull request if that's helpful but I thought I'd ask first to judge how it might be received.Describe alternatives you've considered
I've thought about writing a Gerrit plugin to include additional information in the event payload but then I'd have to write more Java and that's no fun.
Additional context
Full example of what I'm hoping for:
The text was updated successfully, but these errors were encountered: