Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different trigger parameter operations (#315) #319

Merged
merged 2 commits into from
Jul 27, 2019

Conversation

marxarelli
Copy link
Contributor

Implemented an additional operation field for trigger parameters that
dictates what is to be done with the current value at dest. Possible
keyword values are:

  • overwrite Overwrite the current value (default/prior behavior)
  • prepend Prepend the value at dest with the value at source.path
  • append Append the value at dest with the value at source.path

Implemented an additional `operation` field for trigger parameters that
dictates what is to be done with the current value at `dest`. Possible
keyword values are:

 - `overwrite` Overwrite the current value (default/prior behavior)
 - `prepend` Prepend the value at `dest` with the value at `source.path`
 - `append` Append the value at `dest` with the value at `source.path`
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2019

CLA assistant check
All committers have signed the CLA.

@VaibhavPage VaibhavPage self-requested a review July 27, 2019 12:21
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@VaibhavPage VaibhavPage merged commit 1d51b87 into argoproj:master Jul 27, 2019
@marxarelli
Copy link
Contributor Author

Thanks for the merge!

@VaibhavPage
Copy link
Contributor

#315

juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
…oj#319)

* Support different trigger parameter operations (argoproj#315)

Implemented an additional `operation` field for trigger parameters that
dictates what is to be done with the current value at `dest`. Possible
keyword values are:

 - `overwrite` Overwrite the current value (default/prior behavior)
 - `prepend` Prepend the value at `dest` with the value at `source.path`
 - `append` Append the value at `dest` with the value at `source.path`

* Specified that `operation` is optional and generated openapi specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants