chore: updating stan eventbus sts instead of recreating when there is change #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change Signed-off-by: Derek Wang <whynowy@gmail.com>
sarabala1979
approved these changes
Jun 27, 2022
whynowy
added a commit
that referenced
this pull request
Sep 10, 2022
… change (#2054) * chore: updating stan eventbus sts instead of recreating when there is change Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's spec change in nats eventbus, the statefulset will be recreated, which will cause downtime.
This PR changes it to be updating the statefulset - this is based on the assumption that users know only limited fields (e.g. replicas) can be changed for statefulset, most of them are immutable. If fields like pvc need to be updated, deleting and recreating is required.
Signed-off-by: Derek Wang whynowy@gmail.com
Checklist: