Feat/allow replica of 1 for Jetstream #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…goproj#2774) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…proj#2780) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…goproj#2781) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: Ali Koyuncu <ali.koyuncu@iceye.fi> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…goproj#2790) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…#2789) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…roj#2787) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…rgoproj#2788) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…proj#2791) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…roj#2797) Signed-off-by: Liam Wyllie <risset@mailbox.org> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…roj#2795) Signed-off-by: gokulav137 <gokulav999@gmail.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…goproj#2803) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…proj#2801) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…rgoproj#2806) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…ervicebus from 1.4.0 to 1.4.1 (argoproj#2808) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…roj#2807) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…goproj#2804) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…oproj#2815) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…rgoproj#2816) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…68 (argoproj#2817) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…roj#2818) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…rgoproj#2819) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
…proj#2821) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Signed-off-by: Tommi Hovi <tommi.hovi@gmail.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
joelcomp1
force-pushed
the
feat/allow-replica-of-1
branch
from
b8a4334
to
1111e21
Compare
whynowy
reviewed
Sep 27, 2023
| @@ -32,9 +32,6 @@ func ValidateEventBus(eb *v1alpha1.EventBus) error { | |||
| if x.Version == "" { | |||
| return fmt.Errorf("invalid spec: a version for jetstream needs to be specified") | |||
| } | |||
| if x.Replicas != nil && *x.Replicas < 3 { | |||
There was a problem hiding this comment.
To disallow replicas==2 or replicas<=0?
There was a problem hiding this comment.
Yes good point, I'll add that check now
| @@ -436,7 +436,7 @@ func (i *natsInstaller) buildConfigMap() (*corev1.ConfigMap, error) { | |||
| ssName := generateStatefulSetName(i.eventBus) | |||
| replicas := i.eventBus.Spec.NATS.Native.GetReplicas() | |||
| if replicas < 3 { | |||
| replicas = 3 | |||
| i.logger.Errorw("streaming recommends a replica size >= 3, '%v'", replicas) | |||
There was a problem hiding this comment.
Shall we keep the legacy nats streaming untouched, since it's already EOL?
There was a problem hiding this comment.
I hadn't even thought about that, do you have a preference? Not sure how much NATS streaming is still used
There was a problem hiding this comment.
This is the file for nats streaming installation, I would recommend to keep it untouched.
verify replica is 1 or >= 3
whynowy
reviewed
Oct 3, 2023
| @@ -436,7 +436,7 @@ func (i *natsInstaller) buildConfigMap() (*corev1.ConfigMap, error) { | |||
| ssName := generateStatefulSetName(i.eventBus) | |||
| replicas := i.eventBus.Spec.NATS.Native.GetReplicas() | |||
| if replicas < 3 { | |||
| replicas = 3 | |||
| i.logger.Errorw("streaming recommends a replica size >= 3, '%v'", replicas) | |||
There was a problem hiding this comment.
This is the file for nats streaming installation, I would recommend to keep it untouched.
| replicas := i.eventBus.Spec.NATS.Native.Replicas | ||
| if replicas < 3 { | ||
| replicas = 3 | ||
| i.logger.Errorw("streaming recommends a replica >= 3, '%v'", replicas) |
There was a problem hiding this comment.
Use Warnw, and make the log message a complete sentence.
There was a problem hiding this comment.
I reverted this back instead of fixing it since it was in the same file as above with the STAN implementation
|
Sorry for the late response! |
|
reverted back the nats.go file to leave STAN untouched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2743
Tested using the following EventBus Config:
yaml spec: jetstream: imagePullSecrets: - name: private-registry replicas: 1 version: 2.9.19Using Argo Events 1.8.1 with these changes. Then in my Argo Event helm chart I updated the stream config:
## Event bus configuration configs: ## JetStream event bus jetstream: streamConfig: # -- Number of replicas, defaults to 3 and requires minimal 3 replicas: 1Need to fix issue with the nats.conf config map when replica of 3 is used