fix: Eventsource resourse label selector operators not working #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add all sprig functions to templates (argoproj#2768)
…r correctly - For Exists and DoesNotExists value is set to empty if no value is provided when creating label requirement - For In and NotIn value is split by "," to create label requirement Signed-off-by: gokulav137 <gokulav999@gmail.com>
- Test equality operators =, == and in - Test inequality operators != and notin - Test greater than operator and lower than operator - Test exists operator and doesnot exist operator - Test comma separated values for in - Test invalid operators <= and >= Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
whynowy
reviewed
Sep 12, 2023
| @@ -250,7 +250,14 @@ func LabelReq(sel v1alpha1.Selector) (*labels.Requirement, error) { | |||
| if sel.Operation != "" { | |||
| op = selection.Operator(sel.Operation) | |||
| } | |||
| req, err := labels.NewRequirement(sel.Key, op, []string{sel.Value}) | |||
| values := []string{sel.Value} | |||
| if (op == selection.Exists || op == selection.DoesNotExist) && sel.Value == "" { | |||
There was a problem hiding this comment.
Return an error when sel.Value != ""?
There was a problem hiding this comment.
If operator is exists or doesnotexists, an error will be thrown from labels.NewRequirement if values is not empty.
Invalid value: []string{""}: values set must be empty for exists and does not exist
Should I add an error from our end? @whynowy
| @@ -250,7 +250,14 @@ func LabelReq(sel v1alpha1.Selector) (*labels.Requirement, error) { | |||
| if sel.Operation != "" { | |||
| op = selection.Operator(sel.Operation) | |||
| } | |||
| req, err := labels.NewRequirement(sel.Key, op, []string{sel.Value}) | |||
| values := []string{sel.Value} | |||
There was a problem hiding this comment.
Start with var values = make([]string, 0), and use if else?
There was a problem hiding this comment.
Makes sense will make the change
There was a problem hiding this comment.
Used switch and var []string instead of if else block due to linting error.
whynowy
changed the title
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
gokulav137
force-pushed
the
fix-label-selector-exist-and-doesnot-exist
branch
2 times, most recently
from
7b256a7
to
3030191
Compare
whynowy
approved these changes
Sep 12, 2023
joelcomp1
pushed a commit
to joelcomp1/argo-events
that referenced
this pull request
Sep 26, 2023
…roj#2795) Signed-off-by: gokulav137 <gokulav999@gmail.com> Signed-off-by: jmillage <jmillage@bcubed-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #2775
Fixed Exist and DoesNotExist throwing error
2023-08-26T14:33:06.147Z ERROR argo-events.eventsource eventsources/eventing.go:564 Failed to start listening eventsource {"eventSourceName": "notification", "eventSourceType": "resource", "eventName": "completed-workflows", "error": "failed after retries: failed to create the label selector for the event source completed-workflows, values: Invalid value: []string{\"\"}: values set must be empty for exists and does not exist"}Fixed documentation mentioning unsupported operators
Add multiple value support for In and NotIn using comma seperator
Checklist: