Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace antonmedv/expr with expr-lang/expr #2850

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

terrytangyuan
Copy link
Member

The current link is down and the author has created a fork in expr-lang. We use a replace here since the original repo would likely recover once GitHub handles the issue.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@whynowy
Copy link
Member

whynowy commented Oct 9, 2023

@terrytangyuan - what happened with the original link?

@terrytangyuan
Copy link
Member Author

@terrytangyuan
Copy link
Member Author

Let's hold off on merging until the original author confirms.

@terrytangyuan terrytangyuan marked this pull request as draft October 9, 2023 17:31
@terrytangyuan terrytangyuan marked this pull request as ready for review October 9, 2023 18:39
@terrytangyuan
Copy link
Member Author

The author confirmed so we should be good to proceed

@terrytangyuan
Copy link
Member Author

@whynowy would you like to merge this?

@whynowy whynowy merged commit 9c219e3 into argoproj:master Oct 12, 2023
8 checks passed
@terrytangyuan terrytangyuan deleted the fix-expr branch October 12, 2023 16:51
terrytangyuan added a commit that referenced this pull request Oct 19, 2023
gokulav137 pushed a commit to gokulav137/argo-events that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants