Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicationSet chart #577

Merged
merged 9 commits into from
Mar 31, 2021
Merged

Add ApplicationSet chart #577

merged 9 commits into from
Mar 31, 2021

Conversation

maruina
Copy link
Contributor

@maruina maruina commented Feb 11, 2021

Checklist:

  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

Marked as draft because I haven't tested it yet. Tested with helm3 and kind.

Notes:

@maruina maruina force-pushed the argo-appset branch 2 times, most recently from 9e4b1d7 to e67dee8 Compare February 12, 2021 08:42
@maruina
Copy link
Contributor Author

maruina commented Feb 12, 2021

I had to add maintainers for passing the linting stage. I'm happy to help with that, but feel free to tell me I should remove myself and suggest who should be the maintainers :)

@OmerKahani
Copy link

I had to add maintainers for passing the linting stage. I'm happy to help with that, but feel free to tell me I should remove myself and suggest who should be the maintainers :)

you are welcome to stay the maintainer, you created this 👏 👏 👏

@maruina
Copy link
Contributor Author

maruina commented Feb 14, 2021

Tested with helm 3

❯ helm upgrade -i argocd-applicationset . --namespace argocd --set installCRDs=false

@OmerKahani the linting is failing because of the CRD version. In the applicationset project is still v1beta1 as per https://github.com/argoproj-labs/applicationset/blob/master/manifests/crds/argoproj.io_applicationsets.yaml, but if I change it to v1 I get the following error

Error: failed to install CRD crds/crd-applicationset.yaml: CustomResourceDefinition.apiextensions.k8s.io "applicationsets.argoproj.io" is invalid: spec.versions[0].schema.openAPIV3Schema: Required value: schemas are required

I think there is probably some work to be done in the appset repo?

@maruina maruina force-pushed the argo-appset branch 3 times, most recently from d1d6082 to e97822c Compare February 14, 2021 20:54
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>

Add maintainers

Add args

Add new values to readme

feat: allow custom labels in server ingress (argoproj#575)

Signed-off-by: Artyom Bakhtin <a@bakhtin.net>

Fix CRD schema

Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>

Add rbac for leader election

Fix arguments and remove probes

Follow argo-cd chart naming convention

Add installation instructions

Add helm3 crd hook

Fix addresses

Use function instead of fixed name

Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>

fix: updated CRDs for v1.8.4 (argoproj#576)
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
@maruina maruina marked this pull request as ready for review February 19, 2021 08:41
@maruina
Copy link
Contributor Author

maruina commented Feb 24, 2021

/assign @OmerKahani

Copy link

@OmerKahani OmerKahani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maruina
Copy link
Contributor Author

maruina commented Feb 26, 2021

@OmerKahani do you know who should we ask for an approval?

@kvendingoldo
Copy link

@maruina great PR! Don't you think that in the future this chart will be merged with a base argo-cd chart?

@OmerKahani
Copy link

@OmerKahani do you know who should we ask for an approval?

try to send it in the #argo-helm channel

@maruina
Copy link
Contributor Author

maruina commented Feb 27, 2021

@kvendingoldo I think there is a plan to move ApplicationSet inside ArgoCD in the future. I was keeping it separated until the merge happens.

Do you think it should already be part of the regular ArgoCD chart? I'm happy to move it there.

@OmerKahani thanks, I'll go have a look

@kvendingoldo
Copy link

@OmerKahani @alexec @alexmt @jessesuen can you check it, please?

@alexec alexec merged commit 37cd1ef into argoproj:master Mar 31, 2021
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Sep 7, 2021
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants