-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApplicationSet chart #577
Conversation
ae0b4e0
to
32e4ed7
Compare
9e4b1d7
to
e67dee8
Compare
I had to add |
you are welcome to stay the maintainer, you created this 👏 👏 👏 |
Tested with helm 3
@OmerKahani the linting is failing because of the CRD version. In the applicationset project is still v1beta1 as per https://github.com/argoproj-labs/applicationset/blob/master/manifests/crds/argoproj.io_applicationsets.yaml, but if I change it to
I think there is probably some work to be done in the appset repo? |
d1d6082
to
e97822c
Compare
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com> Add maintainers Add args Add new values to readme feat: allow custom labels in server ingress (argoproj#575) Signed-off-by: Artyom Bakhtin <a@bakhtin.net> Fix CRD schema Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com> Add rbac for leader election Fix arguments and remove probes Follow argo-cd chart naming convention Add installation instructions Add helm3 crd hook Fix addresses Use function instead of fixed name Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com> fix: updated CRDs for v1.8.4 (argoproj#576)
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
/assign @OmerKahani |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@OmerKahani do you know who should we ask for an approval? |
@maruina great PR! Don't you think that in the future this chart will be merged with a base argo-cd chart? |
try to send it in the #argo-helm channel |
@kvendingoldo I think there is a plan to move ApplicationSet inside ArgoCD in the future. I was keeping it separated until the merge happens. Do you think it should already be part of the regular ArgoCD chart? I'm happy to move it there. @OmerKahani thanks, I'll go have a look |
@OmerKahani @alexec @alexmt @jessesuen can you check it, please? |
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Checklist:
Chart.yaml
following Semantic Versioning.Changes are automatically published when merged to
master
. They are not published on branches.Marked as draft because I haven't tested it yet.Tested with helm3 and kind.Notes:
Leader election tested but not working. See leader election not working applicationset#124Tested leader election with 2 replicas and it's working fine.