-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traefik Support #516
Comments
we already use traefik ingressroute for blue/green deployment, we would like to try rollout once it supports traefik |
We want to leverage traefk for cananry deployment.
what code level changes i need to do to make it work? since it's written in Chinese, I am finding it difficult to follow. |
It seems that Traefik will have an implementation for the Kubernetes Gateway API https://gateway-api.sigs.k8s.io/implementations/#traefik So Traefik support might be available after implementing #1438 |
Can I take it please ? |
Is this possible today? |
* Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Traefik support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Traefik support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Update traefik Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Implement traefil support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add traefik tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Goimports Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test to trafiicrouting_test.go Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Remove added test to trafficrouting_test.go Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Generate new files Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add mocks Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back apimachinery package version Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Revert "Back apimachinery package version" This reverts commit 34c61b8. Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Fix Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Bump Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add field doc Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Removew verifyWeight and add permissions Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change manifests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Fix tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Bump Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add documentation Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Refactor Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> Co-authored-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com>
* Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make Traefik suppurt Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Traefik support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Traefik support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Update traefik Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Implement traefil support Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add traefik tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Goimports Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test to trafiicrouting_test.go Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Remove added test to trafficrouting_test.go Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Generate new files Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add mocks Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back apimachinery package version Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Revert "Back apimachinery package version" This reverts commit 34c61b8. Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Fix Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Bump Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add field doc Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Make codegen Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Removew verifyWeight and add permissions Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Back go.yml Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Change manifests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Fix tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add tests Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add test Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Bump Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Add documentation Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com> * Refactor Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Refactor Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> * Bump Signed-off-by: PhilippPlotnikov <philipp.plotnikov@codefresh.io> Co-authored-by: PhilippPlotnikov <70917163+PhilippDeveloper@users.noreply.github.com>
In addition to the current controllers, it would be great to support Traefik!
The TraefikService object supports the ability for weighted round robin load balancing and traffic mirroring when using Traefik as ingress.
As a quick pass, an
IngressRoute
is configured to send traffic to aTraefikService
, which then provides configuration for sending traffic to one or more KubernetesService
objects. While I haven't dived into Argo's architecture, I imagine it wouldn't be too complicated to own and manage the TraefikService object.While I may not be the best to contribute code, I could try or help with docs and testing the implementation. Or if someone wants to chat on Slack and give me direction on how/where to get started, I can take a crack at it.
The text was updated successfully, but these errors were encountered: