Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API support for Argo rollouts #1438

Closed
mark-church opened this issue Aug 23, 2021 · 14 comments
Closed

Gateway API support for Argo rollouts #1438

mark-church opened this issue Aug 23, 2021 · 14 comments
Assignees
@PhilippPlotnikov
Labels
enhancement New feature or request traffic-routing

Comments

@mark-church
Copy link

Gateway API is a standard out of SIG-Network that evolves the ingress interface with more advanced capabilities such as weight-based load balancing. There are already many Gateway API implementations that exist including Kong, Traefik, Istio, GKE, and more. This tutorial shows how traffic splitting works in Gateway.

This issue is to propose Gateway API-based support for Argo rollouts so that any Gateway API implementation can be used with Argo in the same way.

cc @bowei @robscott
@mark-church mark-church added the enhancement New feature or request label Aug 23, 2021
@jessesuen
Copy link
Member

As with our support for SMI, this makes perfect sense to me, and would help to alleviate the many direct integration requests that we often get.

@kostis-codefresh kostis-codefresh mentioned this issue Sep 8, 2021
Open
This was referenced Sep 8, 2021
Closed
Closed
Closed
Open
Closed
@jessesuen jessesuen added this to the v1.3 milestone Feb 9, 2022
@lukasmrtvy lukasmrtvy mentioned this issue Feb 24, 2022
Closed
@PhilippPlotnikov
Copy link
Contributor

I would like to implement it

@alexmt
Copy link
Contributor

alexmt commented Mar 17, 2022

Thank you @PhilippPlotnikov

@mainey
Copy link

mainey commented Mar 31, 2022

would it be possible to support KrakenD api gateway for argo rollouts as well?

@object88
Copy link

object88 commented Apr 4, 2022

My apologies if "me too"s aren't appropriate for issues here, but we (Dexcare) are very interested in a Gateway API implementation in Argo Rollouts. @PhilippPlotnikov , is there a way that we can track progress on this? I may be able to contribute some testing time in our development environment.

@PhilippPlotnikov
Copy link
Contributor

PhilippPlotnikov commented Apr 27, 2022 •
edited
Loading

@object88 yes, of course #2004. Here I have made the support but without tests, Im in process. I tested locally it works.

@PhilippPlotnikov
Copy link
Contributor

I have finished PR with Gateway API support, can someone review it please ?
#2004

@harikrongali harikrongali modified the milestones: v1.3, v1.4 Jun 30, 2022
@zachaller zachaller modified the milestones: v1.4, v1.5 Dec 1, 2022
@SebastianScherer88 SebastianScherer88 mentioned this issue Feb 6, 2023
Closed
@zachaller zachaller removed this from the v1.5 milestone Feb 28, 2023
@PhilippPlotnikov
Copy link
Contributor

Hi, I have implemented Gateway API plugin, you can try to test it
https://github.com/argoproj-labs/rollouts-gatewayapi-trafficrouter-plugin

@robscott
Copy link

This is great @PhilippPlotnikov, thanks! Would welcome a PR to reference this on Gateway API's documentation: https://gateway-api.sigs.k8s.io/implementations/#integration-status.

@PhilippPlotnikov
Copy link
Contributor

@robscott hi! Sure, I will try to create PR on the next week

@kostis-codefresh
Copy link
Member

@robscott PR is here kubernetes-sigs/gateway-api#1836

@kostis-codefresh
Copy link
Member

@zachaller

We have now tested three independent implementations for Gateway API and they all work just fine with the plugin

I suggest we mark this issue as closed.

@kostis-codefresh
Copy link
Member

@object88 if you have time for testing, it would be great to add more examples in the plugin repositories with different implementations of the Gateway API

@kostis-codefresh kostis-codefresh mentioned this issue Jun 7, 2023
Closed
@zachaller
Copy link
Collaborator

Closing because it is implemented as a plugin

@ilrudie ilrudie mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippPlotnikov PhilippPlotnikov

Labels
enhancement New feature or request traffic-routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@zachaller @robscott @alexmt @mainey @object88 @jessesuen @mark-church @kostis-codefresh @harikrongali @PhilippPlotnikov